Reintroduce library_path.sh patches from humble to fix LD_LIBRARY_PATH pollution#233
Closed
Ryan4253 wants to merge 1 commit into
Closed
Reintroduce library_path.sh patches from humble to fix LD_LIBRARY_PATH pollution#233Ryan4253 wants to merge 1 commit into
Ryan4253 wants to merge 1 commit into
Conversation
Contributor
Author
|
The CI is failing because diagnostics_remote_logging failed to build. While this was added as an ignore to vinca.yaml it seems like the newest version of diagnostics (4.2.7) adds it as a dependency so it was pulled in transitively. I took a look around different PRs and the windows CI seems to have been failing for a while. Should be irrelevant to this PR. A proper fix would be to patch diagnostics_remote_logging or to exclude it as a diagnostics dep from windows too. |
Contributor
|
I'm happy to cherry-pick this into #212 |
Contributor
Author
|
Feel free to do whatever to get this landed asap |
Contributor
|
cherry-picked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #228
As title (reasoning are addressed in the issue). This restores the humble patches that were deleted in this commit. I couldn't find a reason why these patches were deleted rather than migrated to Jazzy unfortunately
There are three patches in humble that touches
library_path.sh:ament-package- The patch that deleteslibrary_path.shis taken from humble. The second hunk that modifiestemplates.pyto use importlib for file operations is already modernized in Jazzy so I omitted it.ament-cmake-core- The patch is taken verbatim from humbleros-workspace- The patch with equivalent content already exists for jazzy hereVerification:
git apply --checklibrary_path.{sh, dsv}and theirlocal_setupreferences.$CONDA_PREFIX/libno longer appears inLD_LIBRARY_PATH,ros2/rclpystill load, and system binaries like git now runsNote: A rebuild of all packages that uses
library_path.shwill likely be needed after this merge