Skip to content

Update pinnings (mainly assimp 6)#81

Open
diegoferigo-rai wants to merge 34 commits into
RoboStack:mainfrom
diegoferigo-rai:diegoferigo/update-pins
Open

Update pinnings (mainly assimp 6)#81
diegoferigo-rai wants to merge 34 commits into
RoboStack:mainfrom
diegoferigo-rai:diegoferigo/update-pins

Conversation

@diegoferigo-rai

@diegoferigo-rai diegoferigo-rai commented May 26, 2026

Copy link
Copy Markdown
Contributor

Follows up:

that achieved a successful rebuild without updating any package pinning (from #79 (comment)).

Hopefully fixing:

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Thanks @diegoferigo-rai! I'd be keen to fix #76 while we are at it .. @diegoferigo-rai @traversaro @eholum would any of you be happy to try @traversaro's suggested patch?

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Same error as RoboStack/ros-jazzy#212 (comment)

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

What do you think we should do here @traversaro ?

@traversaro

Copy link
Copy Markdown
Member

What do you think we should do here @traversaro ?

I would just revert the patch to https://github.com/RoboStack/ros-jazzy/blob/main/patch/ros-jazzy-rosidl-generator-py.osx.patch, perhaps by just changing the line target_include_directories(${_target_name_lib} PUBLIC ${Python3_INCLUDE_DIRS} ${Python3_NumPy_INCLUDE_DIRS}) to target_include_directories(${_target_name_lib} PRIVATE ${Python3_INCLUDE_DIRS} ${Python3_NumPy_INCLUDE_DIRS}) to also fix RoboStack/ros-jazzy#213 .

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Hi @diegoferigo-rai - are you happy to include the patch suggested by @traversaro, so we can merge here?

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Added the patch - @traversaro do you think we should merge?

@diegoferigo-rai

Copy link
Copy Markdown
Contributor Author

Wow, this ended up being a substantial amount of work! Thanks, @Tobias-Fischer, for driving this forward.

It makes me wonder whether the project could leverage copilot cloud agents to create many of these fixes automatically. It seems like a great use case, although I don't have direct experience setting them up and I'm not sure what the current limitations are for open-source projects.

@diegoferigo-rai diegoferigo-rai marked this pull request as ready for review June 22, 2026 07:41
@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Many of my fixes are thanks to Codex locally. Agreed we might want to give the GitHub agents a go.

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

That said, as far as I understand GitHub agents are constrained to a single repository, so they would rediscover the same fixes over and over for each distribution ..

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Assuming the Windows build passes, are we happy to merge here @traversaro @wep21 @diegoferigo-rai @wolfv?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants