Fix github actions failure on Windows #1376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes GitHub Actions failures on Windows by adding explicit Python 3.11 setup to the Windows build and test workflow. The node-gyp build tool and ROS2 both require Python to be available, and the windows-2025 runner apparently doesn't have Python pre-installed or doesn't have the correct version available by default.
Changes:
- Added Python 3.11 setup step before ROS2 installation in the Windows workflow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes GitHub Actions failures on Windows by adding explicit Python 3.11 setup to the Windows build and test workflow. The
node-gypbuild tool and ROS2 both require Python to be available, and thewindows-2025runner apparently doesn't have Python pre-installed or doesn't have the correct version available by default.Changes:
Fix: #1377