Minor Dockerfile optimizations#288
Minor Dockerfile optimizations#288amarburg wants to merge 7 commits intoRobotic-Decision-Making-Lab:mainfrom
Conversation
|
Hm, odd that ROS-Industrial CI is now breaking. Debugging ... Hm, so ROS-industrial CI is looking for |
|
As a note, as expected, industrial CI does work if we force it to run on "humble" (where mavros is available through rosdep), but fails for "rolling" (and presumably "jazzy") |
| - IMAGE: rolling-ci | ||
| ROS_DISTRO: rolling | ||
| - IMAGE: humble-ci | ||
| ROS_DISTRO: humble |
There was a problem hiding this comment.
As noted, industrial CI tries to install mavros viaapt, which is currently not available for rolling (#248).
CI does work if we force it to use Humble, for which there's a binary image.
Note this is just the ros_industrial CI stage, not building the Docker images (where Mavros is built from source for rolling/jazzy.
There was a problem hiding this comment.
Thanks for looking into that. Because we know it's an issue with MAVROS, It's not a big deal if the CI fails in this PR. We can just update the CI stage in #241 to use the new mavros stage.
Changes Made
Cleaned up and focused version of #226.
An opinionated cleanup of the dockerfile. Includes:
In the "ci" image:
*/package.xml(requires the recent "copy --parent" syntax in the Dockerfile) andblue.reposinto theciimage, rather than the full contents of this repo. I believe this prevents changes to e.g. files in.docker/from breaking cache.vcs import < blue.reposso rosdep dependencies for those packages are also installed in the CI image.In the "robot" image:
This doesn't include some of the more opinionated hadolint changes (e.g. gosu, etc). This PR is focused on moving relatively static steps (apt-get) above cache-breaking changes (pulling files from the local filesystem)
Associated Issues
None
Testing
Completed "joystick teleoperation" demo with built images in
rollingandjazzy