Update Mavlink git repo, remove hot-patching of mavros and mavlink code#358
Conversation
|
Depending on the state of #324 , this may be obsolete.... |
evan-palmer
left a comment
There was a problem hiding this comment.
Just need to revert the target organization in the build then this should be good to go.
|
I'm still mystified at how I end up with such a long trail of commits. Let me do a little rebasing and I'll push a more surgical update. |
d734edf to
4c4d003
Compare
|
For those keeping track at home, I'm able to replicate the build error ( No solution yet... |
|
Appears to be an upstream change in the parser for docker-buildx v0.19.x (possibly related to the Release note for v0.19.1, though v0.19.1/v0.19.2 do not fix it). These latest versions of buildx don't like the syntax As a hack, pin buildx to v0.18.0 in the Github workflow. Added the fix to this PR rather than starting another because I'm not (much of) a sadist. Simple to cherry-pick the change into #324 if we want to abandon this PR. |
|
Thanks for working on this. I don't see any problem with pinning the version as a quick fix. Would you be willing to submit an issue so that we don't forget about that? |
|
Changes Made
This PR updates the current
mainwhich still builds mavros and mavlink from source .... with the understanding that it's not long for this world (Issue #324). But it un-breaks CI until that happens.mavlinkfromhttps://github.com/ros2-gbp/mavlink-gbp-release.gitrather thanmavlink/mav-gdp-release.git. The latter is out of date.Associated Issues
Please provide a list of all open issues that this PR will close or contribute
toward closing.
Notably, does not fix #324