Skip to content

Conversation

@jmartinezojeda
Copy link
Contributor

@jmartinezojeda jmartinezojeda commented Feb 8, 2024

This pull request includes several changes to the logging functionality in the rcomponent package. The most important changes involve removing the log file handling mechanism and updating the logging client initialization accordingly.

Removal of log file handling:

  • src/rcomponent/log_client.py: Removed the log_file parameter from the LogClient class constructor and all associated code for handling log files, including the creation and writing of log files when the service is unavailable. [1] [2] [3]

Update to logging client initialization:

  • src/rcomponent/rcomponent.py: Updated the initialize_logger method to initialize the LogClient without the log_file parameter. Also removed the retrieval of the log_file parameter in the ros_read_params method. [1] [2]

@rafa-martin rafa-martin force-pushed the ros-devel branch 5 times, most recently from 4fdb521 to 80644af Compare February 21, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants