fix(api): URL-encode searchText in chat.search#1150
Open
Shreyas2004wagh wants to merge 1 commit intoRocketChat:developfrom
Open
fix(api): URL-encode searchText in chat.search#1150Shreyas2004wagh wants to merge 1 commit intoRocketChat:developfrom
Shreyas2004wagh wants to merge 1 commit intoRocketChat:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes improper URL construction in the API wrapper by ensuring user-provided searchText is correctly URL-encoded when calling chat.search, preventing reserved characters from corrupting query parsing.
Changes:
- Updated
getSearchMessagesto build query parameters viaURLSearchParams. - Removed direct string interpolation of
searchTextinto the request URL.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix URL encoding in chat.search query params
Acceptance Criteria fulfillment
getSearchMessagesto encode query parameters usingURLSearchParams.searchTextis safely encoded (&,?,#,%,+, spaces).Fixes #1149
PR Test Details
yarn workspace @embeddedchat/api build(passed).searchText.