Skip to content

Comments

Automate build, test, and publish workflows#59

Draft
d-gubert wants to merge 3 commits intomasterfrom
cursor/automate-build-test-and-publish-workflows-4015
Draft

Automate build, test, and publish workflows#59
d-gubert wants to merge 3 commits intomasterfrom
cursor/automate-build-test-and-publish-workflows-4015

Conversation

@d-gubert
Copy link
Member

Add GitHub Actions workflows for CI (lint, typecheck, build, test) on push/PR and for release (CI + publish to npm) on release events.


Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Sep 12, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@d-gubert
Copy link
Member Author

@cursor fix the error reported in the CI workflow

@cursor
Copy link

cursor bot commented Sep 12, 2025

I refactored the ESLint configuration by converting the .eslintrc file to a JavaScript module and explicitly invoking the local ESLint binary. Crucially, I also removed the .eslintignore file, which expands the scope of linting to all project files.

  • I deleted the .eslintignore file, which means ESLint will now process files that were previously ignored, such as node_modules, !.scripts, and *.d.ts files.
  • I renamed .eslintrc to .eslintrc.js and converted its content from a JSON object to a JavaScript module using module.exports, updating all property keys to be unquoted for standard JS object literal syntax.
  • I modified the lint script in package.json from npx eslint src/**/*.ts to ./node_modules/.bin/eslint src/**/*.ts to explicitly use the locally installed ESLint binary.

2 tasks completed

  • Create new eslint.config.js file for ESLint v9 compatibility
  • Remove deprecated .eslintrc file
Open in Cursor Open in Web

Learn more about Cursor Agents

@d-gubert d-gubert force-pushed the cursor/automate-build-test-and-publish-workflows-4015 branch from 9c669c5 to d8b450b Compare September 12, 2025 19:13
@Dnouv
Copy link
Member

Dnouv commented Sep 15, 2025

@d-gubert Can we also take care of the prettier formatting?

@d-gubert
Copy link
Member Author

@d-gubert Can we also take care of the prettier formatting?

Not really on CI, we shouldn't end up modifying the source code during the workflow. What we can do is have a pre-commit hook that will fix lint/formatting errors

@d-gubert d-gubert force-pushed the cursor/automate-build-test-and-publish-workflows-4015 branch from d8b450b to f295017 Compare September 15, 2025 20:24
cursoragent and others added 3 commits September 16, 2025 11:30
Co-authored-by: douglas.gubert <douglas.gubert@rocket.chat>
Co-authored-by: douglas.gubert <douglas.gubert@rocket.chat>
Co-authored-by: douglas.gubert <douglas.gubert@rocket.chat>
@d-gubert d-gubert force-pushed the cursor/automate-build-test-and-publish-workflows-4015 branch from f295017 to ee8196a Compare September 16, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants