Conversation
a478f56 to
68f4d71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #28964 +/- ##
===========================================
- Coverage 48.51% 48.43% -0.08%
===========================================
Files 697 697
Lines 13913 13913
Branches 2447 2447
===========================================
- Hits 6750 6739 -11
- Misses 6787 6792 +5
- Partials 376 382 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
|
What's the criteria for splitting something into a separate service or not? |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Rafael Tapia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Proposed changes (including videos or screenshots)
We're extracting the service creation from PR #27024 in worder to facilitate reviews and discussions.
Here we're just introducing the new services; the adoption of those services is mostly intended to change in future PRs
Issue(s)
Steps to test or reproduce
Further comments
AECO-119