Skip to content

Comments

fix(i18n): correct Swedish translation for User_joined_the_team#38904

Open
farapholch wants to merge 1 commit intoRocketChat:developfrom
farapholch:fix/swedish-translation-user-joined-team
Open

fix(i18n): correct Swedish translation for User_joined_the_team#38904
farapholch wants to merge 1 commit intoRocketChat:developfrom
farapholch:fix/swedish-translation-user-joined-team

Conversation

@farapholch
Copy link

@farapholch farapholch commented Feb 22, 2026

Description

Fixes #38903

The Swedish translation for User_joined_the_team incorrectly uses the imperative form "anslut" (a command to join) instead of the past tense "anslöt" (joined).

Changes

  • packages/i18n/src/locales/sv.i18n.json: Changed "User_joined_the_team": "anslut till teamet" to "User_joined_the_team": "anslöt till teamet"

Context

This string is displayed when a user joins a team. The current translation reads as a command ("join the team") rather than a statement ("joined the team").

The similar key User_joined_team is already correctly translated as <strong>anslöt</strong> till teamet.

Summary by CodeRabbit

  • Localization
    • Swedish language translations have been refined and improved to ensure grammatical accuracy and consistency across all user-facing notification messages. These updates enhance message clarity for Swedish-speaking users and provide proper, natural communication of team activities and user interactions throughout the application platform, resulting in a more polished user experience.

Change "anslut till teamet" (imperative) to "anslöt till teamet" (past tense)
to correctly indicate that the user has joined, not a command to join.

Fixes RocketChat#38903

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 22, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2026

⚠️ No Changeset found

Latest commit: 3a84683

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 22, 2026

No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3145c41 and 3a84683.

📒 Files selected for processing (1)
  • packages/i18n/src/locales/sv.i18n.json
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
🔇 Additional comments (1)
packages/i18n/src/locales/sv.i18n.json (1)

5384-5384: Translation update looks correct.

Past tense now matches the “user joined” event context.


Walkthrough

Swedish locale translation corrected for the User_joined_the_team key, changing from imperative form "anslut till teamet" (join the team) to past tense "anslöt till teamet" (joined the team) to accurately reflect the context where a user has already joined.

Changes

Cohort / File(s) Summary
Swedish Translation Fix
packages/i18n/src/locales/sv.i18n.json
Updated User_joined_the_team translation from imperative "anslut till teamet" to past tense "anslöt till teamet" for grammatical accuracy.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A tiny tweak, but oh so fine,
Swedish words now align—
From "join" to "joined," the tense takes flight,
Past tense shines where imperative lost sight! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix(i18n): correct Swedish translation for User_joined_the_team' directly summarizes the main change: correcting a Swedish translation for a specific key, which is the core objective of the changeset.
Linked Issues check ✅ Passed The PR fully addresses issue #38903 by changing the Swedish translation for User_joined_the_team from 'anslut till teamet' (imperative) to 'anslöt till teamet' (past tense), meeting all coding requirements.
Out of Scope Changes check ✅ Passed The PR contains only the single targeted change to the Swedish translation in sv.i18n.json; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swedish translation error: User_joined_the_team uses imperative instead of past tense

2 participants