Improvment for umbrel installs in custom directories#23
Open
guiand888 wants to merge 1 commit intoRooSoft:mainfrom
Open
Improvment for umbrel installs in custom directories#23guiand888 wants to merge 1 commit intoRooSoft:mainfrom
guiand888 wants to merge 1 commit intoRooSoft:mainfrom
Conversation
Owner
|
@dsbaars do you still animate some RoF? Been a while since I've had the chance to do it, would be nice to have someone competent review this nice little PR, but I don't feel like the right one to do it. Thanks @guiand888! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If user has Umbrel in a customer directory, the script will fail. Not a frequent occurence but this is an option in the Umbrel install script.
One workaround would be to:
docker exec -i lightning_lnd_1 lncliinsteadThis also nulls the need to do a version check. The lnd container name has remained the same since inception.