facing and formation for hero (discovered via ce)#11
Open
Serpen wants to merge 1 commit intoRoseKavalier:masterfrom
Open
facing and formation for hero (discovered via ce)#11Serpen wants to merge 1 commit intoRoseKavalier:masterfrom
Serpen wants to merge 1 commit intoRoseKavalier:masterfrom
Conversation
| h3unk8 _f_47; | ||
| h3unk8 _f_48; | ||
| /** @brief [47] direction in which the hero looks*/ | ||
| h3unk8 faceing; |
Owner
There was a problem hiding this comment.
Change to an INT8 (0..7)
And rename 'facing' without the 'e'.
RoseKavalier
requested changes
Jun 21, 2024
| /** @brief [47] direction in which the hero looks*/ | ||
| h3unk8 faceing; | ||
| /** @brief [48] selected formation type for troups*/ | ||
| h3unk8 formationType; |
Owner
There was a problem hiding this comment.
Change to UINT8.
This is a bitfield, bit 0 is formation (tight/loose) and bit 1 is tactics enabled/disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add 2 missing fields for hero
found them out via cheatengine (and observing)