Fix #1: 🎯 Fix URL Parameter Loss When Request Context is Replaced in Middleware After Routing#6
Open
diptikhaparde-coder wants to merge 1 commit into
Conversation
Resolved functional logic defect and ensured proper cleanup. Signed-off-by: diptikhaparde-coder <dipti.khaparde@adraca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request resolves issue #1: 🎯 Fix URL Parameter Loss When Request Context is Replaced in Middleware After Routing.
Technical Details
Resolved context propagation defect: Implemented a fix to ensure that the
chi.Contextis correctly attached and propagated when a request is cloned usingr.WithContext(newCtx). This was achieved by introducing a helper functionWithRouteContextincontext.goto manage the attachment ofchi.Contextto the new context, preventing premature release back to thesync.Pool.Middleware enhancement for context preservation: Added middleware in
middleware.goto preserve thechi.Contextwhen requests are cloned. This middleware ensures that the routing context is maintained across cloned requests, addressing the issue of context loss during request cloning.Submitted cleanly via verified engineering workflow.