feat: implement Essentials module with TPA command functionality#27
Open
Foxof7207 wants to merge 4 commits into
Open
feat: implement Essentials module with TPA command functionality#27Foxof7207 wants to merge 4 commits into
Foxof7207 wants to merge 4 commits into
Conversation
Rothes
reviewed
May 16, 2026
|
|
||
| override fun onEnable() {} | ||
|
|
||
| data class Lang( |
Owner
There was a problem hiding this comment.
This can be moved to Tpa feature, so tpa prefix on key can be simplified.
Put a empty class Lang(): ConfigurationPart here.
| object Tpa : CommonFeature<FeatureToggle.DefaultTrue, Unit>() { | ||
|
|
||
| // target -> requester | ||
| private val pendingRequests = mutableMapOf<UUID, UUID>() |
Owner
There was a problem hiding this comment.
Potential memory leak. Consider using a Cache, or remove keys on player disconnect.
|
|
||
| @Command("tpaccept [requester]") | ||
| @ShortPerm | ||
| fun tpaccept(sender: User, requester: Player?) { |
Owner
There was a problem hiding this comment.
I think you can set a default value for requester param, to pendingRequests[sender.uuid],
So it's possible not to call Bukkit.getPlayer() ?
… configuration to the Tpa module
…esolve command parameter issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.