Skip to content

Add support for SuSE and initd/systemd selection#11

Open
michaelsstuff wants to merge 5 commits into
RoushTech:masterfrom
michaelsstuff:master
Open

Add support for SuSE and initd/systemd selection#11
michaelsstuff wants to merge 5 commits into
RoushTech:masterfrom
michaelsstuff:master

Conversation

@michaelsstuff

Copy link
Copy Markdown

Added supoprt for openSuse (leap and thumbleweed 42.x)
removed a lot of exec for the download and tar, to follow best practice and not use exec, but archive
Added if clause in params to query for os and version, to select init or systemd; not perfect but works for the defined systems.

Added factor query in params.pp for automated selection of initd or systemd for the supported OS
added Suse init file
@StrangeWill

Copy link
Copy Markdown
Contributor

Dunno how I missed this -- is this still good?

@michaelsstuff

Copy link
Copy Markdown
Author

Yes and no. It should work, but I found a few minutes or mistakes I need to fix. I will try to work on it this week

@StrangeWill

Copy link
Copy Markdown
Contributor

No rush, just let me know, and thanks. 👍

@michaelsstuff

Copy link
Copy Markdown
Author

c272bc1 is tested on openSuse 42 and CentOS 7.3
I wanted to rewrite the params to data-in-module style (like the ntp module, with hiera in the module), but that would take some time. It would make adding new OS to the modukle quiete easy. What do you think?

@StrangeWill

Copy link
Copy Markdown
Contributor

I've never done data-in-module style I don't think, I've always wired my stuff up in roles generally... but I've always wanted to spend the time to go back and add native hiera support.

Feel free to tell me you're done here if you're not needing it badly enough to implement it yourself and I'll look into what that'll take on my end.

@michaelsstuff

Copy link
Copy Markdown
Author

Let's close this pull, as it works on suse.
Hiera and data-in-module is nice but definitely for another pull ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants