HW2 Complete Panda and Tiger Level. #12
Open
jomarquez wants to merge 1 commit intoRubyoffRails:masterfrom
Open
HW2 Complete Panda and Tiger Level. #12jomarquez wants to merge 1 commit intoRubyoffRails:masterfrom
jomarquez wants to merge 1 commit intoRubyoffRails:masterfrom
Conversation
Member
|
Hi! Did you mean to close the pull request? |
Author
|
Hola! Sorry, no I did not mean to close it. I have reopened it... |
Member
There was a problem hiding this comment.
sooo, this method breaks a couple of my rules for better code:
- it is longer than 4 lines long.
- it has a begin/rescue that continues on in the method
- it has more than 1 line inside of the begin/rescue
Alternatively, I recommend:
def find_movie(movies_hash)
movies = fetch_movie
###... more code
end
def fetch_movie
puts "Add a movie you really like"
movie_title = gets.chop
begin
Api.search_by_title(movie_title)
rescue MovieNotFoundError => e
puts e
puts "Error " #...
end
end
You'd then made the Api raise a MovieNotFoundError if a movie wasn't found
Member
|
Hi Joanna -- functionally, it looked good! I added some comments about the find_movie method that might help keep code easy to read later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.