Assignment #2

[annavester]

Here is my Panda Level, I am still working on the rest... Thanks!

[jwo]

Here you're returning a string that has a semantic meaning of "nothing was found". So this method could either return:

• string with "Not Found"
• Movie object with information

I think either raising an exception, or a specific NilMovie would be more expressive of what happened.

[jwo]

Left you a suggestion on how you're handling the not-found... looks promising! Let me know if you have questions on the string vs object stuff.

[annavester]

@jwo Jesse, I've updated the way I raise the exception. I think this looks better, right?

[jwo]

@annavester I think it's better for sure. I would recommend that instead of catching the NotMethodError, we try to catch something a little more close to the domain. maybe something like this:

class MovieNotFoundError; end

#...
  raw_result_json = get_url_as_json(url)
  build_movie_from_result(raw_result_json)
end

def build_movie_from_result(json)
  if json["movies"].count > 0
    struct = OpenStruct.new(.fetch("movies").first)
  else
    raise MovieNotFoundError
  end
end

Now, the API will raise a MovieNotFoundError, and you can catch it in the movie_json workflow and handle it there.

Maybe:

begin
  movie = Api.search_by_title(movie_title)  
  puts "Found: #{movie.title}. Score: #{movie.score}"
rescue Api::MovieNotFoundError
  outs "Movie was not found :( :( "
end