Conversation
|
Hi! Just wanted to let you know I got the Pull Request... I looked it over and it looks good. I'll be doing a more intensive review in the next 1-2 days. until then: 👍 |
|
Ok so I left some questions --- overall a nice job! Yay! |
|
Done |
There was a problem hiding this comment.
why delete README? if you're going to, you should replace it witch your own readme.
There was a problem hiding this comment.
Thanks Jesse,
I’m not sure why the README page got axed.
I was just probably frustrated and took it out on the README page.
I put it back and added your suggestions.
I have a general question though about pull requests.
If I send you an initial request, and then alter my master…will it automatically change it in the pull request I sent you?
On Nov 6, 2013, at 10:42 AM, Jesse Wolgamott notifications@github.com wrote:
In README.md:
@@ -1,50 +0,0 @@
-Episode3: Watchman -- Datastores in YML and Postgres
why delete README? if you're going to, you should replace it witch your own readme.—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Yep. as you push more code to github in your repo, if you have an existing pull-request that will get updated.
If you're feeling advanced, you can have multiple branches that each could have their own pull request (though that gets complicated easily). For more on git:
2 participants
No description provided.