Es walberla#47
Open
itischler wants to merge 2 commits into
Open
Conversation
python interface. If they are not set directly they will be set via viscosity and magic number
Owner
|
Thank you. I just tried merging this PR.
Could you please centralize the viscosity to relaxation rate (and back) conversion in functions, e.g., in src/walberla_bridge/lb_relaxation_rates.hpp? and also the shear viscosity from relaxation rates. You could than expose this to Python, do any conversion of user input there, and have the entire construction path just once with RelaxationRates as argument. I deferred merging for now, particularly, since the lb_stats.py and lb_thermostat.py tests are broken. Could you please take an other look? (FYI: @jngrad) |
47db0d3 to
4075cb7
Compare
4e447de to
376d80b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes espressomd#4028