chore(validation): speed up pre-push checks#1122
Closed
jSydorowicz21 wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches local pre-push validation from a repo-wide full gate to changed-file checks for formatting and ESLint. The full repo validation remains available as
bun run validate:push:fullor by settingMAESTRO_FULL_PUSH_VALIDATE=1before pushing.Why
The previous
.husky/pre-pushpath ran repo-wide Prettier, all TypeScript project checks, all ESLint, and the full Vitest suite on every push. That made normal branch pushes slow enough to time out during issue-triage work, even after targeted tests had already passed.Changes
scripts/validate-push-fast.tsto derive changed files from Git pre-push stdin, with manual-run fallback for committed, staged, unstaged, and untracked files.validate:pushto call the fast validator by default.validate:push:fullfor the previous full repo gate usingbun run.bunxinstead ofnpxfor staged-file checks..husky/pre-push.Validation
bun scripts/validate-push-fast.tsbun run validate:push:fastbunx prettier --check --ignore-unknown .husky/pre-push .husky/pre-commit .husky/pre-merge-commit package.json scripts/validate-push-fast.tsgit diff --checkbun scripts/validate-push-fast.tssh .husky/pre-pushsh .husky/pre-pushgit push -u fork fix/fast-local-validation, which ran the fast hook successfully