리팩토링

[unam98]

📌 개요

✨ 작업 내용

• 방문자 모드 뷰 중앙 배치
• 중복 코드 공통화
• 하드코딩 스트링 리소스화

✨ PR 포인트

📸 스크린샷/동영상

Summary by CodeRabbit

• New Features
  • Unified visitor mode across My Page and Storage: shows a focused signup prompt when not logged in and hides member-only content.
  • Added consistent “가입하기” button behavior that navigates to login/signup.
• Refactor
  • Streamlined screen initialization to load member content only when applicable, improving responsiveness.
  • Consolidated visitor-mode UI into dedicated containers for cleaner, more consistent layouts.
• Style
  • Replaced hard-coded texts with localized string resources for visitor-mode messages and button labels.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces BaseVisitorFragment to centralize visitor/content mode handling. Refactors MyPageFragment and StorageMainFragment to extend it, moving initialization into onContentModeInit and wiring visitor containers. Updates two fragment layouts to wrap visitor UI in cl_visitor_mode containers and adds new visitor-mode strings.

Changes

Cohort / File(s)	Summary
Visitor base abstraction app/src/main/java/com/runnect/runnect/binding/BaseVisitorFragment.kt	Added abstract BaseVisitorFragment<T: ViewDataBinding> managing visitor vs. content modes, requiring visitorContainer, contentViews, and onContentModeInit. Handles visibility toggling and login navigation.
MyPage refactor to base app/src/main/java/com/runnect/runnect/presentation/mypage/MyPageFragment.kt	Switched base to BaseVisitorFragment. Implemented visitorContainer/contentViews. Moved setup into onContentModeInit. Simplified navigation and loading handling; added helpers and consolidated stamp resource resolution.
Storage refactor to base app/src/main/java/com/runnect/runnect/presentation/storage/StorageMainFragment.kt	Switched base to BaseVisitorFragment. Implemented visitorContainer/contentViews. Moved initialization into onContentModeInit. Removed prior visitor-mode checks/logging; adjusted unknown tab handling to default to StorageMyDrawFragment.
MyPage layout visitor container app/src/main/res/layout/fragment_my_page.xml	Replaced root-level visitor views with cl_visitor_mode container holding iv_visitor_mode, tv_visitor_mode, btn_visitor_mode in a packed vertical chain. Texts now use @string resources. Container default visibility set to invisible.
Storage layout visitor container app/src/main/res/layout/fragment_storage_main.xml	Introduced cl_visitor_mode wrapping visitor views in a packed vertical chain; removed standalone visitor views. tv_visitor_mode uses @string/visitor_mode_storage_message. Container controls group visibility.
Visitor strings app/src/main/res/values/strings.xml	Added visitor_mode_mypage_message, visitor_mode_storage_message, visitor_mode_signup_btn. No existing strings changed.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Activity as MainActivity
  participant Frag as BaseVisitorFragment (Subclass)
  participant Login as LoginActivity

  User->>Activity: Open screen
  Activity->>Frag: onViewCreated()
  Frag->>Activity: Check isVisitorMode
  alt Visitor mode
    Frag->>Frag: Show visitorContainer<br/>Hide contentViews
    User->>Frag: Tap btn_visitor_mode
    Frag->>Login: navigateToLogin()
    Login-->>Activity: Start & finish current
  else Content mode
    Frag->>Frag: Hide visitorContainer<br/>Show contentViews
    Frag->>Frag: onContentModeInit()
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I twitch my ears at visitor gates,
A toggle flips, the UI waits—
One hop to Login, swift and clean,
Or onward to content, crisp and lean.
New strings sing softly, layouts align—
Two tabs, one base, all working fine. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e51282d and 7363da5.

📒 Files selected for processing (6)

• app/src/main/java/com/runnect/runnect/binding/BaseVisitorFragment.kt (1 hunks)
• app/src/main/java/com/runnect/runnect/presentation/mypage/MyPageFragment.kt (5 hunks)
• app/src/main/java/com/runnect/runnect/presentation/storage/StorageMainFragment.kt (2 hunks)
• app/src/main/res/layout/fragment_my_page.xml (1 hunks)
• app/src/main/res/layout/fragment_storage_main.xml (1 hunks)
• app/src/main/res/values/strings.xml (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/guest-view-center-position

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.