Conversation
f859e30 to
05084f4
Compare
|
I've tested this locally with a bunch of variations: path legacy, path new, git legacy, git new, git 2024 PR (expected fail), path 2024 PR rebased (works) |
| object.insert("build".to_owned(), build); | ||
|
|
||
| Ok(cli_args_json) | ||
| Ok(serde_json::to_value(crate::build::Build::parse_from( |
There was a problem hiding this comment.
these are some of the commits I cherry-picked from my library refactor :D
05084f4 to
876d1cc
Compare
f1d9c5a to
1a1f673
Compare
8fc529a to
fb10e19
Compare
|
Rust-GPU/rust-gpu#256 got merged, so I'm just waiting for LegNeato to publish a version of |
|
@Firestar99 done! I tried to add you as an owner but it said name not found...you might need to log into crates.io or something 🤷 |
…en_spirv_target_specs`, with legacy fallback
fb10e19 to
fd5da3c
Compare
|
@tombh @schell this one is ready for final review and merge. I've updated We should consider adding more CI (in a later PR?) to:
|
|
Edit: you merged as I was typing! I was going to say that Schell knows this part of the code better than me. But anyway, all good. |
|
It was set to auto-merge after approval |
Requires publishing
rustc_backend_spirv-target-specsand updating the commit rev ofspirv-builderrust-gpu: Rust-GPU/rust-gpu#256
Rust-GPU/rust-gpu#249 (comment)
Note: replace
rustc_codegen_spirv-typeswith the newrustc_codegen_spirv-target-specscrateRust-GPU/rust-gpu#249 (comment)