Conversation
dpi crate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
WindowInfo,Size,Point,PhySizeandPhyPointtypes, and replaces them with types from thedpicrate.This provides usability improvements compared to the old types, as well as better ecosystem integration (since those types are used widely in the Rust GUI ecosystem).
This change also enables a couple more improvements, which this PR provides:
dpi::Sizetype inWindowOpenOptions::sizeandWindowContext::resize, allowing users to pass either physical or logical sizes.WindowEvent::Resizedevent to its ownWindowContext::resizedhandler, properly indicating that window resizes are not an event that can be captured or ignored.WindowSizetype used in theresizedhandler, providing both physical and logical sizes with the guarantee that one of them came directly from the underlying platform APIs. This prevents having to do back-and-forth conversions that can be lossy due to rounding.