Conversation
MichaelHills
left a comment
There was a problem hiding this comment.
Change looks fine, is the failing macOS nightly check anything to worry about?
Seems kinda serious to me. This is among a ton of warnings. I guess they are all in the bindgen generated tests, at which point it might be interesting to maybe create a bindgen isue (if there isn't one already). @simlay does |
Interesting. Yeah, Should we choose to do the quick fix of simply removing I can't say that bindgen has always had lots of warnings but as the compiler has grown, it's added more and more warnings to enable better safety and so that's there's so many. Anyway, it's unclear what the correct work around is as this is explicitly in the generated unit tests. |
|
Oh no, I hope they revert rust-lang/rust#95372 , at least until there is a solution for it on stable. |
|
There aren't any real tests except for the ones generated by bindgen, whose failing is beyond our control, so maybe one can switch to |
Follow up from #54.