feat(srp): add HomeKit-compatible padding options for u and M1/M2#272
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Mar 25, 2026
Merged
feat(srp): add HomeKit-compatible padding options for u and M1/M2#272tarcieri merged 1 commit intoRustCrypto:masterfrom
tarcieri merged 1 commit intoRustCrypto:masterfrom
Conversation
Contributor
Author
|
@tarcieri friendly ping on this PR |
Member
|
Hi @r4v3n6101! Sorry, this one went through the cracks but it would be definitely nice to get a HomeKit-compatible exchange added. I'll try to take a look later today. |
tarcieri
approved these changes
Mar 25, 2026
Contributor
Author
|
@tarcieri could you please bump a version? I would like to update my code to use new API, but from crates.io instead of git ref. |
Member
|
I ended up reverting this in #283 due to sporadic test failures |
tarcieri
added a commit
that referenced
this pull request
Mar 30, 2026
…283) This reverts commit 5b33c78 (#272) This is causing sporadic test failures which weren't caught in CI. This shows we need improved testing (e.g. `proptest`) cc @r4v3n6101
tarcieri
added a commit
that referenced
this pull request
Mar 30, 2026
There is apparently a bug in #272 which caused sporadic test failures that this would've caught
tarcieri
added a commit
that referenced
this pull request
Mar 30, 2026
There is apparently a bug in #272 which caused sporadic test failures that this would've caught
Member
|
@r4v3n6101 if you'd like to try re-applying this, #284 should now catch the bug, whatever it was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uparameter. It usesPAD(A)andPAD(B)as specified in doc comment, though it wasn't implemented. (RFC)H(g), useful for Apple's HomeKit protocol.Linked issue: #204