Add From impls between ByteArray and EncodedUint#1064
Merged
Conversation
One thing lost from #1016 is the ability to convert from `Uint::Repr` and `hybrid_array::Array<u8, _>`. Arguably these cases should use the dedicated `ArrayEncoding`/`ArrayDecoding` traits for this purpose instead, but for the sake of retrofitting the changes from #1016 this adds back the ability to do these conversions for `EncodedUint` up to 16 limbs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1064 +/- ##
==========================================
+ Coverage 78.82% 78.84% +0.01%
==========================================
Files 173 174 +1
Lines 17659 17675 +16
==========================================
+ Hits 13920 13936 +16
Misses 3739 3739 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing lost from #1016 is the ability to convert from
Uint::Reprandhybrid_array::Array<u8, _>.Arguably these cases should use the dedicated
ArrayEncoding/ArrayDecodingtraits for this purpose instead, but for the sake of retrofitting the changes from #1016 this adds back the ability to do these conversions forEncodedUintup to 16 limbs.