Support mixed-size comparisons for Integer types#1184
Open
andrewwhitehead wants to merge 3 commits intoRustCrypto:masterfrom
Open
Support mixed-size comparisons for Integer types#1184andrewwhitehead wants to merge 3 commits intoRustCrypto:masterfrom
andrewwhitehead wants to merge 3 commits intoRustCrypto:masterfrom
Conversation
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
commented
Feb 3, 2026
| #[inline] | ||
| fn ct_assign(&mut self, other: &Self, choice: Choice) { | ||
| debug_assert_eq!(self.bits_precision(), other.bits_precision()); | ||
| assert_eq!(self.bits_precision(), other.bits_precision()); |
Contributor
Author
There was a problem hiding this comment.
Changed to an assert because this cannot succeed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1184 +/- ##
==========================================
+ Coverage 86.74% 86.86% +0.11%
==========================================
Files 182 182
Lines 20384 20446 +62
==========================================
+ Hits 17683 17760 +77
+ Misses 2701 2686 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewwhitehead
commented
Feb 3, 2026
| #[inline] | ||
| fn ct_select(&self, other: &Self, choice: Choice) -> Self { | ||
| debug_assert_eq!(self.bits_precision(), other.bits_precision()); | ||
| assert_eq!(self.bits_precision(), other.bits_precision()); |
Contributor
Author
There was a problem hiding this comment.
Changed to an assert as the wrong value might be produced otherwise.
andrewwhitehead
commented
Feb 3, 2026
| #[inline] | ||
| fn ct_swap(&mut self, other: &mut Self, choice: Choice) { | ||
| debug_assert_eq!(self.bits_precision(), other.bits_precision()); | ||
| assert_eq!(self.bits_precision(), other.bits_precision()); |
Contributor
Author
There was a problem hiding this comment.
Changed to an assert because this could silently fail.
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unifies the comparison methods between
Int,Uint, andBoxedUint, andUintRef.