Rename UnsignedMontyForm => UnsignedWithMontyForm#1189
Open
Rename UnsignedMontyForm => UnsignedWithMontyForm#1189
UnsignedMontyForm => UnsignedWithMontyForm#1189Conversation
Based on feedback it was a bit unclear what this trait actually did. This hopefully helps clarify that this type is an unsigned integer type which has an associated `*MontyForm` type which uses that integer type as its internal representation.
Member
Author
|
FYI @fjarri, breaking change that will need a coordinated release with |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1189 +/- ##
=======================================
Coverage 86.72% 86.72%
=======================================
Files 182 182
Lines 20390 20390
=======================================
Hits 17683 17683
Misses 2707 2707 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback it was a bit unclear what this trait actually did. This hopefully helps clarify that this type is an unsigned integer type which has an associated
*MontyFormtype which uses that integer type as its internal representation.