Skip to content

polyval: get rid of transmute #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Feb 3, 2026
Merged

polyval: get rid of transmute #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions polyval/src/field_element/armv8.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

use super::FieldElement;
use crate::Block;
use core::{arch::aarch64::*, mem};
use core::arch::aarch64::*;
use universal_hash::array::{Array, ArraySize};

/// 128-bit SIMD register type.
Expand Down Expand Up @@ -185,7 +185,7 @@ unsafe fn mont_reduce(x23: Simd128, x01: Simd128) -> Simd128 {
#[inline]
#[target_feature(enable = "aes,neon")]
unsafe fn pmull(a: Simd128, b: Simd128) -> Simd128 {
mem::transmute(vmull_p64(
vreinterpretq_u8_p128(vmull_p64(
vgetq_lane_u64(vreinterpretq_u64_u8(a), 0),
vgetq_lane_u64(vreinterpretq_u64_u8(b), 0),
))
Expand All @@ -195,7 +195,7 @@ unsafe fn pmull(a: Simd128, b: Simd128) -> Simd128 {
#[inline]
#[target_feature(enable = "aes,neon")]
unsafe fn pmull2(a: Simd128, b: Simd128) -> Simd128 {
mem::transmute(vmull_p64(
vreinterpretq_u8_p128(vmull_p64(
vgetq_lane_u64(vreinterpretq_u64_u8(a), 1),
vgetq_lane_u64(vreinterpretq_u64_u8(b), 1),
))
Expand Down