Conversation
Member
Author
|
Clippy errors are unrelated to changes in this PR. |
tarcieri
reviewed
Nov 28, 2020
tarcieri
approved these changes
Nov 29, 2020
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
Okay sorry, it took me awhile to figure out this is all working as expected, but now I've tested it out empirically and it seems to be working the way you described.
tarcieri
force-pushed
the
cpuid_bool2
branch
from
4f337b1 to
81691bd
Compare
Member
|
Fixed clippy in #87 and rebased. Should be good to merge/release now. |
Member
|
@newpavlov can you publish the crate? I don't have access. |
Member
Author
|
I plan to do it on the 1st of December as specified in the changelog. I will add you to the owners list a bit later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new API creates a module which contains
InitTokenzero sized type. The only way to create a value of this type is via functions which ensure that initialization code has been executed. It should be slightly more efficient for our use-cases, since initialization branch can be eliminated from methods which work with initialized algorithm (e.g.updateandencrypt_blocks/decrypt_blocks).In future it could be beneficial to add "cpuid enums", i.e. macro which would generate code not for a
bool, but for a user-specified enum.