UI-20 :: Fix Lack of MCap In Coin Item#85
Open
essy16 wants to merge 3 commits into
Open
Conversation
added 3 commits
July 7, 2023 23:59
RyanKoech
reviewed
Jul 27, 2023
|
|
||
| val coinMarketCapString = context.getString( | ||
| (R.string.coin_market_cap), df.format(value), "") | ||
| return " $coinMarketCapString" |
Owner
There was a problem hiding this comment.
You don't need these return statements inside. It is all being handled in the outside return statement in the begin of this if else chain. Refer to the original implementation. The only change should be in line 94:
| color = getChangeColor(coin.change) | ||
| ) | ||
| Spacer(modifier = Modifier.weight(1.0f)) | ||
| Text(text = "MCap", style = MaterialTheme.typography.body2) |
Owner
There was a problem hiding this comment.
Doesn't this product 2 MCap in the Coin Item composable? Kindly run to verify your changes.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@RyanKoech please review