fix: avoid integer overflow in scoring#43
Merged
Merged
Conversation
base * span multiplies user-configured weights by a byte-size span, and could exceed i64 with large weights and multi-gigabyte releases, silently wrapping in release builds and inverting the ranking. Compute the comparison key in i128 instead.
Ryder-C
force-pushed
the
fix-scoring-overflow
branch
from
July 24, 2026 23:39
66eb554 to
ff21787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base * span multiplies user-configured weights and could exceed i64 with large weights and multi-gigabyte releases.
Use i128 instead.