Skip to content

fix: empty string to supported locales to resolve i18n entries within…#1540

Open
815are wants to merge 1 commit intoSAP-samples:mainfrom
815are:fix/i18nWithinManifest
Open

fix: empty string to supported locales to resolve i18n entries within…#1540
815are wants to merge 1 commit intoSAP-samples:mainfrom
815are:fix/i18nWithinManifest

Conversation

@815are
Copy link
Copy Markdown

@815are 815are commented Dec 19, 2025

Issue:

  1. create translation entry for "title": "My Itinerary" like -> "title": "{i18n>myItinerary}"
  2. update i18n.properties file with new entry
myItinerary=My Itinerary
  1. Run preview using cds watch
  2. Open preview for travel_processor and navigate to object page;
  3. Problem - see myItinerary displayed in preview instead of My Itinerary

Problem is that supportedLocales is defined, but does not contain "" which is used by default when we run preview

… preview

empty string to supported locales to resolve i18n entries within preview
@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Dec 19, 2025

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Dec 19, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants