Skip to content

Feature/onpremise unknown filetype km fixes#119

Merged
longieirl merged 27 commits into
mainfrom
feature/onpremise-unknown-filetype-km-fixes
Mar 11, 2026
Merged

Feature/onpremise unknown filetype km fixes#119
longieirl merged 27 commits into
mainfrom
feature/onpremise-unknown-filetype-km-fixes

Conversation

@longieirl
Copy link
Copy Markdown
Member

Pull Request

What does this PR do?

Checklist

  • Sample tested and runs without errors
  • No sensitive data included

…se README

- Add new troubleshooting section: unknown file type during upload
  (.Ui5RepositoryTextFiles / .Ui5RepositoryBinaryFiles configuration)
- Fix all list markers from * to - throughout, including ToC
- Fix ToC label to title case "Table of Contents"
- Promote "How It Works" from H3 to H2 (heading hierarchy fix)
- Apply sentence case to all H3+ headings
- Fix HTTP 401/403 slash to "HTTP 401 and HTTP 403"
- Replace "backend" with "back-end" throughout prose
- Replace "via Cloud Connector" with "using Cloud Connector"
- Add missing periods to complete sentence list items
- Reorder ToC to match body section order
- Replace em dash separators with colons in Properties list
- Fix "is working" -> "works" (weak phrasing rule)
- Replace arrow separators with colons in 401/403 list
- Add "The" before "SAP Gateway is active"
- Rename "Deployment additional resources" -> "Additional resources for deployment"
- Remove trailing periods from checklist top-level items
- Preserve "Unknown file type during upload" section unique to this branch
@longieirl longieirl self-assigned this Mar 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026

🔗 Link Check Results

The link checker has completed. This is an optional check and will not block the PR.

View workflow run for details

If broken links were found, please review them at your convenience.


Last updated: Run #128 at 2026-03-10T13:50:27Z

@longieirl longieirl requested a review from lfindlaysap March 9, 2026 17:47
@longieirl
Copy link
Copy Markdown
Member Author

@lfindlaysap can you please ensure the headers i.e. # / ## / ### / #### are correct i.e. if they are capital or sentence? I'm tring to narrow the rules down when creating PR's thanks.

Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
@lfindlaysap
Copy link
Copy Markdown
Member

@lfindlaysap can you please ensure the headers i.e. # / ## / ### / #### are correct i.e. if they are capital or sentence? I'm tring to narrow the rules down when creating PR's thanks.

All headers should be title case in line with the Chicago style.

longieirl and others added 10 commits March 10, 2026 12:45
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
@longieirl longieirl requested a review from lfindlaysap March 10, 2026 12:48
longieirl and others added 4 commits March 10, 2026 12:49
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
longieirl and others added 3 commits March 10, 2026 12:49
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Comment thread misc/onpremise/README.md Outdated
Co-authored-by: Louise Findlay <louise.findlay@sap.com>
@longieirl longieirl merged commit acc71ff into main Mar 11, 2026
5 checks passed
@github-actions github-actions Bot deleted the feature/onpremise-unknown-filetype-km-fixes branch March 11, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants