Conversation
Pavan-SAP
added
the
build-pr-images
Pavan-SAP
added
build-pr-images
Pavan-SAP
force-pushed
the
hpa
branch
2 times, most recently
from
b08df77 to
a476c93
Compare
Pavan-SAP
added
build-pr-images
This change enables explicit support for HPA. Doing this within the operator allows us to also cleanup HPAs for older versions (as this is owned by the version). We had to create our own HPA spec as scaleTargerRef is required and the one from the k8s client does not allow to omit it. We cannnot let users specify it as this needs to be set by the operator to the correct deployment values.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables explicit support for HPA.
Doing this within the operator allows us to also cleanup HPAs for older versions (as this is owned by the version).