feat: remove future implementation from the pendingdeployment class#679
Open
feat: remove future implementation from the pendingdeployment class#679
Conversation
Sunil-SKS
force-pushed
the
feat/refactor
branch
3 times, most recently
from
7034ed6 to
d55b69b
Compare
Sunil-SKS
changed the title
ikalachy
reviewed
Feb 18, 2026
| // complete and then undeploy it. pending deployment was completed successfully, undeploy will undeploy | ||
| // it, or otherwise will do nothing because a failed deployment results in a successful undeploy | ||
| return pendingDeployment.transform(deployResult -> pendingDeployment.undeploy()); | ||
| return pendingDeployment.undeploy(); |
Contributor
There was a problem hiding this comment.
pendingDeployment.getDeployment().transform(result -> pendingDeployment.undeploy());
pendingDeployment.undeploy() will fail immediately with IllegalStateException if a deployment is still in progress. The old code used transform() to wait for completion; this waiting mechanism was removed, breaking the undeploy logic during partial deployment failures.
Changes - PendingDeployment
Sunil-SKS
force-pushed
the
feat/refactor
branch
from
d55b69b to
ee79c70
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Future implementation has been removed from PendingDeployment to support the migration from Vert.x 4 to Vert.x 5. The PendingDeployment class now returns objects directly, rather than Futures.