fix: CXSPA-11733 Issues with SSR Cypress E2Es#20996
Merged
pawelfras merged 1 commit intoepic/angular-21-upgradefrom Jan 13, 2026
Merged
fix: CXSPA-11733 Issues with SSR Cypress E2Es#20996pawelfras merged 1 commit intoepic/angular-21-upgradefrom
pawelfras merged 1 commit intoepic/angular-21-upgradefrom
Conversation
Contributor
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
Contributor
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
sdrozdsap
added a commit
that referenced
this pull request
Jan 14, 2026
Nx migration: - "@nx/angular" bumped to 22.3.1 - "@nx/devkit" bumped to 22.3.1 - "@nx/eslint-plugin" bumped to 22.3.1 - "@nx/jest" bumped to 22.3.1 - "@nx/workspace" bumped to 22.3.1 - "nx" bumped to 22.3.1 Angular migration: - "@angular/core" bumped to 21.0.8 - "@angular/animations" bumped to 21.0.8 - "@angular/common" bumped to 21.0.8 - "@angular/compiler" bumped to 21.0.8 - "@angular/forms" bumped to 21.0.8 - "@angular/platform-browser" bumped to 21.0.8 - "@angular/platform-browser-dynamic" bumped to 21.0.8 - "@angular/platform-server" bumped to 21.0.8 - "@angular/router" bumped to 21.0.8 - "@angular/service-worker" bumped to 21.0.8 - "@angular/cli" bumped to 21.0.5 - "@angular/compiler-cli" bumped to 21.0.8 - "@angular/language-service" bumped to 21.0.8 - "@angular/ssr" bumped to 21.0.5 - "@angular/pwa" bumped to 21.0.5 - "@angular/build" bumped to 21.0.5 - "@angular-devkit/build-angular" bumped to 21.0.5 - "@angular-devkit/core" bumped to 21.0.5 - "@angular-devkit/schematics" bumped to 21.0.5 - "@schematics/angular" bumped to 21.0.5 - "@angular-builders/custom-esbuild" bumped to 21.0.0-beta.1 - "ng-packagr" bumped to 21.0.1 - "zone.js" bumped to 0.16.0 Angular ESLint: - "@angular-eslint/builder" bumped to 21.1.0 - "@angular-eslint/eslint-plugin" bumped to 21.1.0 - "@angular-eslint/eslint-plugin-template" bumped to 21.1.0 - "@angular-eslint/schematics" bumped to 21.1.0 - "@angular-eslint/template-parser" bumped to 21.1.0 - "@angular-eslint/test-utils" bumped to 21.1.0 - "@angular-eslint/utils" bumped to 21.1.0 NgRx: - "@ngrx/effects" bumped to 21.0.1 - "@ngrx/operators" bumped to 21.0.1 - "@ngrx/router-store" bumped to 21.0.1 - "@ngrx/store" bumped to 21.0.1 - "@ngrx/store-devtools" bumped to 21.0.1 Other dependencies: - "@ng-select/ng-select" bumped to 21.1.4 - "ngx-infinite-scroll" bumped to 21.0.0 - "jest-preset-angular" bumped to 16.0.0 Build issues: - added global type augmentations for `@HostListener` decorators with platform event syntax see: #20967 - fixed declaration-merging builder for ng-packagr v21 output structure change - updated tsconfig files: changed `module` from `es2022` to `preserve`, added `moduleResolution: bundler` - removed `lib: ["es2022", "dom"]` from tsconfig.lib.json files - removed `isolatedModules` from tsconfig.spec.json files - disabled `prefer-control-flow` ESLint rule Unit tests: - replaced `BrowserDynamicTestingModule`/`platformBrowserDynamicTesting` with `BrowserTestingModule`/`platformBrowserTesting` - added `provideZoneChangeDetection()` via custom `ZoneChangeDetectionModule` in all test config files - updated snapshots across multiple libraries - fixed failing unit tests (checkout components, HorizontalScrollingPositionDirective, guest registration form) - added `transformIgnorePatterns` to jest schematics configs to support ESM modules Schematics: - Installation and migration docs adjustments see: #20970 - Installation script update see: #20987 - Remove redundant 'applyClassicNamingConvention' from schematics see: #20986 - add missing semicolon in the generated app server.ts see: #20988 - Updated schematics snapshots **SSR:** - Issues with SSR Cypress E2Es see: #20996
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cypress tets for SSR were failing due to unexpected

NG0205: Injector has already been destroyedLink to example failing check: https://github.com/SAP/spartacus/actions/runs/20916679856/job/60093114689?pr=20946
Issue was resolved by moving
provideZoneChangeDetectionfrom deprecatedplatformBrowserDynamicinmain.tsto theapp.module.ts, where this config should land, based on the Angular Team recommendation.Apart from that change, the following was changed (not related to the SSR issue)
platformBrowserDynamicreplaced with recommendedplatformBrowserQA steps:
epic/angular-21-upgradecypress.config.ts, change e2e.baseUrl tohttp://localhost:4000e2e: { // We've imported your old cypress plugins here. // You may want to clean this up later by importing these. setupNodeEvents(on, config) { return require('./cypress/plugins/index.js')(on, config); }, - baseUrl: 'http://localhost:4200', + baseUrl: 'http://localhost:4000', },ssr/product-listing-page.e2e.cy.tsNG0205occuredfix/CXSPA-11823ssr/product-listing-page.e2e.cy.tsand verify if all tests passed