fix(packaging): include missing component styles in main bundle#1443
Open
KRUSHAL2956 wants to merge 1 commit into
Open
fix(packaging): include missing component styles in main bundle#1443KRUSHAL2956 wants to merge 1 commit into
KRUSHAL2956 wants to merge 1 commit into
Conversation
Adds chip.css, footer.css, sidebar.css, and scroll-progress.css imports to easemotion.css so all component styles ship in the bundled output. Closes SAPTARSHI-coder#1432
Contributor
Author
|
@SAPTARSHI-coder please review this merge request. This PR imports the missing component stylesheets (chip, footer, sidebar, scroll-progress) in the main entry bundle to fix the packaging omissions. |
Contributor
📊 CSS Bundle Size BenchmarkThis PR changes the size of
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds the missing component stylesheet imports (
chip.css,footer.css,sidebar.css, andscroll-progress.css) to the framework entry bundle (easemotion.css).Type of Change
Submission Checklist
Notes for Maintainer
This PR resolves issue #1432 where several core component stylesheets were omitted from the main bundle entry, making them unavailable when loading
easemotion.css.Closes #1432