fix(ux): resolve broken mobile sidebar close transition by transitioning visibility#1452
Open
KRUSHAL2956 wants to merge 1 commit into
Open
fix(ux): resolve broken mobile sidebar close transition by transitioning visibility#1452KRUSHAL2956 wants to merge 1 commit into
KRUSHAL2956 wants to merge 1 commit into
Conversation
Contributor
Author
|
@SAPTARSHI-coder please review this merge request. This PR fixes the mobile sidebar's exit animation by transitioning visibility instead of display:none, allowing the slide-out transform to complete smoothly. |
Contributor
📊 CSS Bundle Size BenchmarkNo change in CSS bundle size. ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Replaces
display: none/display: blocktoggling on the mobile viewport sidebar panel with animatablevisibility: hidden/visibility: visiblestates, resolving the broken close (exit) slide animation.Type of Change
Submission Checklist
Notes for Maintainer
This PR resolves issue #1441. Since
displaychanges cannot transition in CSS, closing the sidebar on mobile previously caused it to snap closed instantly, completely bypassing thetransform: translateX(-100%)slide-out transition. Transitioningvisibilityalongsidetransformfixes the asymmetric entry/exit animations cleanly.Closes #1441