fix: resolve duplicate and incorrect numbering in student profile rep…#1457
Open
Premshaw23 wants to merge 1 commit into
Open
fix: resolve duplicate and incorrect numbering in student profile rep…#1457Premshaw23 wants to merge 1 commit into
Premshaw23 wants to merge 1 commit into
Conversation
Contributor
✅ Submission Validation Passed!Great job! All required files are present. 📁 Folder:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR resolves the visual indexing bug in the student profile repeater by:
Introducing a helper function reindexBlocks(container, labelPrefix) that iterates through all remaining block cards in the section container.
Dynamically updating their data-index attributes and updating the block header texts (e.g. Project #1, Project #2) to maintain continuous and accurate numbering.
Calling reindexBlocks immediately upon the completion of a block deletion transition.
This fixes visual duplicate numbering while maintaining all user inputs intact since we only modify attributes and text headers of the existing DOM nodes.
closes #1456
Type of Change
Submission Checklist
submissions/examples/your-feature-name/demo.html— self-contained, opens in browser with no serverstyle.css— raw CSS for the proposed featureREADME.md— what it does, how to use it, why it fits EaseMotion CSScore/components/Feature Description
What does this add?
How does a developer use it?
<!-- Show the class usage in HTML -->Why does it fit EaseMotion CSS?
Demo
demo.htmlworks by opening directly in a browser)Browser Testing
Notes for Maintainer