Conversation
…for positioning BGs
freshollie
reviewed
Feb 15, 2026
| #define HEAP_END ewram_end | ||
| #endif | ||
|
|
||
| /* --- HOW THIS WORKS --- |
freshollie
reviewed
Feb 16, 2026
|
|
||
| #if !PLATFORM_GBA && !PLATFORM_SDL | ||
| extern void Platform_DisplaySprite(Sprite *sprite, u8 oamPaletteNum); | ||
| extern void Platform_TransformSprite(Sprite *sprite, SpriteTransform *transform); |
Collaborator
There was a problem hiding this comment.
Do we wanna move these to platform.h or something?
freshollie
reviewed
Feb 16, 2026
src/core.c
Outdated
| u8 gBgSprites_Unknown1[] = {}; | ||
| OamData gOamBuffer[] ALIGNED(16) = {}; | ||
| u16 gVramHeapState[] = {}; | ||
| u16 gVramHeapState[OBJ_VRAM_TOTAL_SIZE / VRAM_HEAP_SEGMENT_SIZE] = {}; |
Collaborator
There was a problem hiding this comment.
Does this need to be sized here?
Collaborator
Author
There was a problem hiding this comment.
Doesn't have to be, but doesn't hurt, either. :D
Though hmm... with it defined in headers, having size auto-allocated might actually be better...
freshollie
reviewed
Feb 16, 2026
src/game/stage/intro.c
Outdated
| b = ((gUnknown_080D6FF5[gSelectedCharacter][i][2] * frameCounter) / 16u); | ||
|
|
||
| gObjPalette[i] = RGB16_REV(r, g, b); | ||
| gObjPalette[0 * 16 + i] = RGB16_REV(r, g, b); |
Collaborator
There was a problem hiding this comment.
Do we wanna make 16 a const?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes: