[WIP] DRAFT Add PSP port with shared fast software renderer#234
Draft
kikugrave wants to merge 6 commits intoSAT-R:mainfrom
Draft
[WIP] DRAFT Add PSP port with shared fast software renderer#234kikugrave wants to merge 6 commits intoSAT-R:mainfrom
kikugrave wants to merge 6 commits intoSAT-R:mainfrom
Conversation
freshollie
reviewed
Feb 15, 2026
| memset(gameImage, 0, sizeof(gameImage)); | ||
| #if RENDERER == RENDERER_SOFTWARE_FAST | ||
| { | ||
| extern void DrawFrame_Fast(uint16_t * pixels); |
Collaborator
There was a problem hiding this comment.
I think this could be moved to a header file?
freshollie
reviewed
Feb 15, 2026
| #define applySpriteVerticalMosaicEffect(y) (y - (y % (mosaicSpriteEffectY + 1))) | ||
|
|
||
| // NOTE: This is the corrected function. | ||
| static void RenderBGScanline(int bgNum, uint16_t control, uint16_t hoffs, uint16_t voffs, int lineNum, uint16_t *line) |
Collaborator
There was a problem hiding this comment.
Does this code need to be changed if you now use fast draw? Or at these bug fixes?
freshollie
reviewed
Feb 15, 2026
| int32_t y = oam->split.y; | ||
|
|
||
| #if !EXTENDED_OAM | ||
| // The regular, unextended values are 9 and 8 unsigned bits for x and y respectively. |
Collaborator
There was a problem hiding this comment.
Why were these comments removed?
freshollie
reviewed
Feb 15, 2026
Comment on lines
+222
to
+226
| sdlRenderer = SDL_CreateRenderer(sdlWindow, -1, SDL_RENDERER_ACCELERATED | SDL_RENDERER_PRESENTVSYNC); | ||
| if (sdlRenderer == NULL) | ||
| sdlRenderer = SDL_CreateRenderer(sdlWindow, -1, SDL_RENDERER_ACCELERATED); | ||
| if (sdlRenderer == NULL) | ||
| sdlRenderer = SDL_CreateRenderer(sdlWindow, -1, 0); |
Collaborator
There was a problem hiding this comment.
Why do we need these fallbacks?
freshollie
reviewed
Feb 15, 2026
|
|
||
| bool newFrameRequested = FALSE; | ||
|
|
||
| // Every GBA frame we process the SDL events and render the number of times |
Collaborator
There was a problem hiding this comment.
Did you intend for these comments to be re-written?
freshollie
reviewed
Feb 15, 2026
|
|
||
| void VDraw(SDL_Texture *texture) | ||
| { | ||
| memset(gameImage, 0, sizeof(gameImage)); |
Collaborator
There was a problem hiding this comment.
Don't reset the image every frame?
kikugrave
changed the title
kikugrave
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT PSP Port Beta