add support for mrc files in float16 format from WarpTools#75
Merged
Conversation
Collaborator
|
Thanks for this PR! Do you by any chance have a link to the documentation for this specific header value? Also, I will add some tests for this functionality after my Christmas break, so it won't be merged before that. |
Contributor
Author
|
@sroet Merry Christmas! Enjoy your break~ |
Collaborator
|
Hey @alncat, sorry this took so long, I read this PR originally on my phone and thought it was for pytom-match-pick. which has stricter testing requirements. PyTom is not regularly tested at the moment, so this PR is good to merge as is! |
Contributor
Author
|
@sroet Thank you for merging it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear PyTom developers,
I note that the pytom doesn't support the mrc files in float16 format yet. Hence, I modified the read_mrc function in
pytom/agnostic/io.py to enable this capacity. I was wondering if this functionality is relevant and can be merged.
Best Regards,
Zhenwei