test: add unit test coverage for attestation path validation#19
Open
corepacket wants to merge 2 commits intoSBOMit:masterfrom
Open
test: add unit test coverage for attestation path validation#19corepacket wants to merge 2 commits intoSBOMit:masterfrom
corepacket wants to merge 2 commits intoSBOMit:masterfrom
Conversation
As requested during code review: - The '--exclude' flag is entirely removed from the CLI interface. - Pattern matching now utilizes 'doublestar' correctly across path boundaries. - Instead of silently dropping files, anomalous files (e.g. '.git/', '*.log') generate a warning to stderr while preserving output integrity. Signed-off-by: corepacket <wbn453177@gmail.com>
Signed-off-by: corepacket <wbn453177@gmail.com>
0808279 to
789bf64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20
This PR adds unit test coverage for the attestation path validation logic introduced in #18.
In PR #18, we introduced a validation mechanism to detect unexpected files in attestations (e.g.,
.gitdirectories and*.logfiles) and surface them as warnings without modifying the original data.This PR builds on that work by adding tests to ensure the validation behaves correctly.
What’s Added
Unit Tests for
matchesPattern.gitdirectories (including nested paths)*.logfilesmygit/...)Unit Tests for
ValidatePathWhy This Change
Notes
testingpackage (no additional dependencies)