Open
Conversation
As requested during code review: - The '--exclude' flag is entirely removed from the CLI interface. - Pattern matching now utilizes 'doublestar' correctly across path boundaries. - Instead of silently dropping files, anomalous files (e.g. '.git/', '*.log') generate a warning to stderr while preserving output integrity. Signed-off-by: corepacket <wbn453177@gmail.com>
Signed-off-by: corepacket <wbn453177@gmail.com>
This change ensures reproducible SBOM output by replacing non-deterministic Go map iteration with sorted iteration of package names. Signed-off-by: corepacket <wbn453177@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22
Background
Previously, the
RustResolveriterated directly over thechosenByNamemap to build the final list of resolved packages. Because Go does not guarantee a consistent map iteration order, running SBOM extraction multiple times on the same target could result in non-deterministic structural outputs. While the generated data remained accurate, the changing order caused headaches when diffing SBOMs, performing auditing, or enforcing reproducibility across builds.Changes
chosenByNamemap.sort.Strings()to ensure lexicographical sorting of the crate names prior to array append.pkg/resolver/rust_test.gowith unit test assertions explicitly validating deterministic ordering and output stability across multiple identical runs.Testing
go test ./...test suites passed downstream.