fix: use dynamic versioning for sbomit generator tool#34
Open
Jaydeep869 wants to merge 1 commit intoSBOMit:masterfrom
Open
fix: use dynamic versioning for sbomit generator tool#34Jaydeep869 wants to merge 1 commit intoSBOMit:masterfrom
Jaydeep869 wants to merge 1 commit intoSBOMit:masterfrom
Conversation
Signed-off-by: jaydeep869 <jaydeeppokhariya2106@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33
This PR addresses an issue where the
sbomitgenerator tool version was hardcoded to"0.0.1"within the generated SBOM metadata (doc.Metadata.Tools). Because of this hardcoding, the tool version remains static and prevents accurate artifact tagging during actual releases (e.g., v1.0.0, v1.1.0).Changes Made:
"0.0.1"string in thesbom.Toolmetadata generation logic (insidecreateDocumentandapplyMetadata) with an exported package levelVersionvariable.Versionvariable and assigned it togenerator.Versionprior to CLI execution. This allows the tool version to be injected seamlessly during the build process using Go linker flags (for ex:-ldflags "-X main.Version=...").How Has This Been Tested?
I verified this works as expected by locally compiling with a spoofed version via
ldflags, and generating an SBOM against a sample attestation.Reproduction Steps:
go build -ldflags "-X main.Version=v1.2.3" -o sbomit main.goversionfield for thesbomittool reportsv1.2.3instead of0.0.1.Types of changes
Checklist: