test(attestation): add parser coverage for witness formats#37
Open
IITI-tushar wants to merge 1 commit intoSBOMit:masterfrom
Open
test(attestation): add parser coverage for witness formats#37IITI-tushar wants to merge 1 commit intoSBOMit:masterfrom
IITI-tushar wants to merge 1 commit intoSBOMit:masterfrom
Conversation
Signed-off-by: Tushar Saxena <019saxenatushar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #36
This pull request adds a comprehensive test suite for the attestation parsing logic. The new tests cover a variety of scenarios for both data and file parsing, including different attestation types, DSSE envelope handling, error cases, and normalization functions. This improves confidence in the correctness and robustness of the attestation parser.
New test coverage for attestation parsing:
ParseWitnessDatato cover direct statements, DSSE envelopes, type filtering, empty inputs, malformed JSON, missing payloads, and multiple attestations of the same type.ParseWitnessFile, including file-not-found errors, valid file parsing, and integration with a real sample attestation file.Attestation type normalization and canonicalization:
canonicalAttestationTypeandnormalizeAttestationTypefunctions, ensuring correct handling of URI-style, shorthand, aliases, and case-insensitive inputs.Test utilities and helpers:
buildInTotoStatement,buildDSSEEnvelope) to generate test data for in-toto statements and DSSE envelopes, facilitating robust and maintainable tests.