test: add core network and python resolver test coverage#9
Open
Jaydeep869 wants to merge 1 commit intoSBOMit:masterfrom
Open
test: add core network and python resolver test coverage#9Jaydeep869 wants to merge 1 commit intoSBOMit:masterfrom
Jaydeep869 wants to merge 1 commit intoSBOMit:masterfrom
Conversation
Fixes SBOMit#7 (or the corresponding issue). Adds network_test.go to cover ExtractConnections and Domain Resolver logic. Adds python_test.go to cover Python PyPI domains URL parsing. Signed-off-by: jaydeep869 <jaydeeppokhariya2106@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces critical test coverage for the new network trace attestation support, mitigating previously absent coverage for
sbomit's unique feature.Fixes #7
Scope of Changes:
pkg/resolver/network/network_test.goto thoroughly testExtractConnections, domain based routing hooks, connection struct parsing, and PURL deduplication.pkg/resolver/network/python_test.goto test PyPI URL parsing (files.pythonhosted.org), package name/version extraction, and validation of success vs. failed HTTP statuses.test/sample-attestation.json.Checklist:
go test ./pkg/resolver/network/...)ExtractConnectionsfunction is fully tested