Skip to content

Fix subregion filter on projects page#457

Merged
Jacobojijo merged 3 commits into
SDG-AI-Lab:developfrom
okjake:projects-subregion-filtering
May 27, 2025
Merged

Fix subregion filter on projects page#457
Jacobojijo merged 3 commits into
SDG-AI-Lab:developfrom
okjake:projects-subregion-filtering

Conversation

@okjake
Copy link
Copy Markdown
Collaborator

@okjake okjake commented May 17, 2025

No description provided.

@Jacobojijo
Copy link
Copy Markdown
Collaborator

Hello Jakes, I have tested the filters on the project page and they work alright. I have noticed that there are also filters on the disasters and technologies page. Kindly have a look at the two too

@okjake
Copy link
Copy Markdown
Collaborator Author

okjake commented May 21, 2025

Hello Jakes, I have tested the filters on the project page and they work alright. I have noticed that there are also filters on the disasters and technologies page. Kindly have a look at the two too

I believe this PR will fix those too

@Jacobojijo
Copy link
Copy Markdown
Collaborator

Hello @okjake, this is a great fix. However it needs further adjustments. Make the filter to be cascading (disasters and technologies page) i.e ensure the subregion options is associated to the selected region (just like the filters on the other pages)

@Jacobojijo
Copy link
Copy Markdown
Collaborator

Jacobojijo commented May 23, 2025

Hello @okjake, thanks for your PR. Kindly fix this
Screenshot from 2025-05-23 13-03-25

the africans subregions are not part of asia

@okjake
Copy link
Copy Markdown
Collaborator Author

okjake commented May 23, 2025

Yeah I see - this is due to deriving the data from the blips and the ambiguity when a project has region ['Africa', 'Asia'] and subregion ['Southern Asia', 'Middle Africa'] for example. I've added a utility to pull and cache the canonical location hierarchy from supabase instead which seems to work better.

Copy link
Copy Markdown
Collaborator

@Jacobojijo Jacobojijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @okjake

@Jacobojijo Jacobojijo merged commit c3bff2f into SDG-AI-Lab:develop May 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants