[Chore] Pageable max size 글로벌 제한 설정#210
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 본 PR은 Spring Data의 페이징 기능을 활용하여 API 요청 시 페이징 사이즈를 전역적으로 100으로 제한하는 설정을 도입했습니다. 이를 통해 개별 컨트롤러에서 반복적으로 수행하던 검증 로직을 제거하고 유지보수성을 향상시켰습니다. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request replaces the manual page size validation in SemoFeedController with a global Spring Web configuration (spring.web.pageable.max-page-size: 100) in application.yaml. The reviewer provided valuable feedback: first, they warned that a global page size limit might negatively impact other APIs (such as admin or bulk data endpoints) that need to fetch more than 100 records; second, they recommended adding slice or integration tests to ensure that requests with a page size greater than 100 are correctly capped at 100.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🧾 요약
🔗 이슈
✨ 변경 내용
spring.data.web.pageable.max-page-size: 100글로벌 설정 추가✅ 확인