Skip to content

[Chore] Pageable max size 글로벌 제한 설정#210

Merged
howooyeon merged 1 commit into
developfrom
chore/#205-pageable-max-size
Jun 9, 2026
Merged

[Chore] Pageable max size 글로벌 제한 설정#210
howooyeon merged 1 commit into
developfrom
chore/#205-pageable-max-size

Conversation

@howooyeon

@howooyeon howooyeon commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🧾 요약

  • Pageable max size 글로벌 제한 설정 추가

🔗 이슈

✨ 변경 내용

  • spring.data.web.pageable.max-page-size: 100 글로벌 설정 추가
  • SemoFeedController 수동 size 검증 로직 및 미사용 import 제거

✅ 확인

  • 빌드 OK
  • 테스트 OK

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 082620c1-e8f2-4455-bc28-1a7c26f07675

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/#205-pageable-max-size

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

본 PR은 Spring Data의 페이징 기능을 활용하여 API 요청 시 페이징 사이즈를 전역적으로 100으로 제한하는 설정을 도입했습니다. 이를 통해 개별 컨트롤러에서 반복적으로 수행하던 검증 로직을 제거하고 유지보수성을 향상시켰습니다.

Highlights

  • 글로벌 페이징 제한 설정: application.yaml에 spring.data.web.pageable.max-page-size: 100 설정을 추가하여 페이징 요청의 최대 크기를 전역적으로 제한했습니다.
  • 코드 중복 제거: SemoFeedController에서 수동으로 수행하던 페이징 사이즈 검증 로직을 제거하여 코드를 간결화했습니다.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@howooyeon howooyeon self-assigned this Jun 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the manual page size validation in SemoFeedController with a global Spring Web configuration (spring.web.pageable.max-page-size: 100) in application.yaml. The reviewer provided valuable feedback: first, they warned that a global page size limit might negatively impact other APIs (such as admin or bulk data endpoints) that need to fetch more than 100 records; second, they recommended adding slice or integration tests to ensure that requests with a page size greater than 100 are correctly capped at 100.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/resources/application.yaml
@howooyeon howooyeon changed the title chore: Pageable max size 글로벌 제한 설정 [chore] Pageable max size 글로벌 제한 설정 Jun 9, 2026
@howooyeon howooyeon changed the title [chore] Pageable max size 글로벌 제한 설정 [Chore] Pageable max size 글로벌 제한 설정 Jun 9, 2026
@howooyeon howooyeon merged commit 9e0088e into develop Jun 9, 2026
3 checks passed
@howooyeon howooyeon deleted the chore/#205-pageable-max-size branch June 10, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[chore] Pageable max size 글로벌 제한 설정

1 participant